search

mfuentesg / SyncSettings

Sync Settings - The cross-platform solution to keep Sublime Text configuration synchronized
https://mfuentesg.dev/SyncSettings
MIT License
288 stars 38 forks source link

Doesn't properly handle binary files #150

Closed TerminalFi closed 4 years ago

TerminalFi commented 4 years ago

If a file is binary, it doesn't base64 encode it first.

Solutions

  1. Check to see if the file is binary, if it is... base64 encode it

or

  1. Treat everything as binary and base64 encode all content
TerminalFi commented 4 years ago

No real go way to do this. If we treat everything as binary and base64 encode everything. Nothing would be easily readable on the gist. But we then wouldn't need to worry about binary data. But I think this defeats the purpose.