Fix/settings location - Githubissues

mfuentesg / SyncSettings

Sync Settings - The cross-platform solution to keep Sublime Text configuration synchronized

https://mfuentesg.dev/SyncSettings

MIT License

288 stars 38 forks source link

Fix/settings location #161

Closed TerminalFi closed 3 years ago

TerminalFi commented 4 years ago

fixes #135

Changes

[x] Side by side setting editing
[x] Configurable setting path
[x] Error handling for config location

Additional formattng @mfuentesg This I just following the pyls provided by sublime LSP. If you don't want these formatting changes, let me know. I will start to disable pyls for this project.

TerminalFi commented 4 years ago

Failed tests, potentially GH issue

TerminalFi commented 4 years ago

Need to fix FileExistError for Python2

mfuentesg commented 4 years ago

@TheSecEng please, try to avoid modifications in unrelated files of this feature.

mfuentesg commented 4 years ago

@TheSecEng please, try to avoid modifications in unrelated files of this feature.

mfuentesg commented 4 years ago

@TheSecEng do you have any update on this to review it?

TerminalFi commented 4 years ago

Ah yes, I was on vacation. Will push request changes today

mfuentesg commented 4 years ago

@TheSecEng you need to use this config in the following files as well.

https://github.com/mfuentesg/SyncSettings/blob/b6a75a1148abdc338316eee82061534b29cf70c1/sync_settings/commands/open_logs.py#L9-L15

https://github.com/mfuentesg/SyncSettings/blob/b6a75a1148abdc338316eee82061534b29cf70c1/sync_settings/sync_version.py#L8-L20

https://github.com/mfuentesg/SyncSettings/blob/b6a75a1148abdc338316eee82061534b29cf70c1/sync_settings/commands/download.py#L15-L18

https://github.com/mfuentesg/SyncSettings/blob/b6a75a1148abdc338316eee82061534b29cf70c1/SyncSettings.py#L7-L9

https://github.com/mfuentesg/SyncSettings/blob/b6a75a1148abdc338316eee82061534b29cf70c1/sync_settings/libs/logger.py#L3-L9

mfuentesg commented 3 years ago

closing due inactivity