search

mfuentesg / SyncSettings

Sync Settings - The cross-platform solution to keep Sublime Text configuration synchronized
https://mfuentesg.dev/SyncSettings
MIT License
288 stars 38 forks source link

Fix bug when URL in config file #176

Closed hans00 closed 4 years ago

mfuentesg commented 4 years ago

@hans00 can you give more context what this is trying to fix? or, can you create an issue for it?

Apart of that, can you add a test of the issue that you are fixing?

mfuentesg commented 4 years ago

Validating the expression some cases are not covered.

i have modified a bit your expression -> https://regex101.com/r/U46FhM/2/, but, i am not able to cover all of the yet.

hans00 commented 4 years ago

Issue #177

hans00 commented 4 years ago

I found decode function in v3 API, but v2 doesn't have. Does we stop support v2?

mfuentesg commented 4 years ago

I tried, but some issues with special chars still happen after using sublime.decode_value or sublime.encode_value

mfuentesg commented 4 years ago

@hans00 i will use your first approach to fix this issue, in order to solve it now. I will spend more time finding another way to cover more escenarios.

https://github.com/mfuentesg/SyncSettings/pull/178