Open shalak opened 2 years ago
To reproduce on fresh installation:
{ "access_token": "your_token", "excluded_files": "someFile.sublime-settings" }
Please note that the excluded_files is a string, where it should be []string.
excluded_files
string
[]string
Expected:
Actual:
The Sublime's console show's the culprit:
Traceback (most recent call last): File "/Users/username/Library/Application Support/Sublime Text/Installed Packages/Sync Settings.sublime-package/sync_settings/commands/create_and_upload.py", line 26, in on_done File "/Users/username/Library/Application Support/Sublime Text/Installed Packages/Sync Settings.sublime-package/sync_settings/sync_manager.py", line 62, in get_files File "/Users/username/Library/Application Support/Sublime Text/Installed Packages/Sync Settings.sublime-package/sync_settings/sync_manager.py", line 36, in should_exclude AttributeError: 'str' object has no attribute 'extend'
I guess we need to check the type before working with the param. Or maybe add schema validation? 🤔
To reproduce on fresh installation:
Please note that the
excluded_files
is astring
, where it should be[]string
.Expected:
Actual:
The Sublime's console show's the culprit:
I guess we need to check the type before working with the param. Or maybe add schema validation? 🤔