mfuentesg / SyncSettings

Sync Settings - The cross-platform solution to keep Sublime Text configuration synchronized
https://mfuentesg.dev/SyncSettings
MIT License
288 stars 38 forks source link

No error message and empty logs with broken config #200

Open shalak opened 2 years ago

shalak commented 2 years ago

To reproduce on fresh installation:

Expected:

Actual:

The Sublime's console show's the culprit:

Traceback (most recent call last):
  File "/Users/username/Library/Application Support/Sublime Text/Installed Packages/Sync Settings.sublime-package/sync_settings/commands/create_and_upload.py", line 26, in on_done
  File "/Users/username/Library/Application Support/Sublime Text/Installed Packages/Sync Settings.sublime-package/sync_settings/sync_manager.py", line 62, in get_files
  File "/Users/username/Library/Application Support/Sublime Text/Installed Packages/Sync Settings.sublime-package/sync_settings/sync_manager.py", line 36, in should_exclude
AttributeError: 'str' object has no attribute 'extend'

I guess we need to check the type before working with the param. Or maybe add schema validation? 🤔