Include SyncSettings.sublime-settings to exclude folders as default?

mfuentesg / SyncSettings

Sync Settings - The cross-platform solution to keep Sublime Text configuration synchronized

https://mfuentesg.dev/SyncSettings

MIT License

288 stars 38 forks source link

Include SyncSettings.sublime-settings to exclude folders as default? #80

Closed fabioperrella closed 5 years ago

fabioperrella commented 7 years ago

Hi, I've noticed that if SyncSettings.sublime-settings file is pushed to github (when upload sync), it triggers a behavior in github to disable the access_token.

Hello fabioperrella,

We noticed that a valid OAuth access token of yours was committed to a public GitHub repository. Publicly disclosing a valid access token would allow other people to interact with GitHub on your behalf, potentially altering data, your contact information, and billing data.

As a precautionary measure, we have revoked the OAuth token...

So my suggestion is to add this file to excluded_files as default, or to add a warning in Readme about it.

Wdyt?

mfuentesg commented 7 years ago

SyncSettings.sublime-settingsis ignored by default when uploading and downloading your settings. It is not necessary add this file to excluded_files option.

fabioperrella commented 7 years ago

But I received this email above many times when using the plugin to upload the settings. It stopped only when I added this file to excluded_files

mfuentesg commented 7 years ago

Ok, i will review this behavior

samhk222 commented 6 years ago

I Just got an email from github issuing the same. As follows

ello samhk222,

We noticed that a valid OAuth access token of yours was committed to a Gist. Disclosing a valid access token would allow other people to interact with GitHub on your behalf, potentially altering data, your contact information, and billing data.

As a precautionary measure, we have revoked the OAuth token. A new token will need to be generated in order to continue using OAuth to authenticate to GitHub. Here are a couple of steps you can do to ensure your account security has not been compromised:

Review any unauthorized OAuth applications, and remove any you don’t recognize: https://help.github.com/articles/reviewing-your-authorized-integrations/#reviewing-your-authorized-oauth-apps
Review you security log to ensure that no malicious activity has occurred: https://help.github.com/articles/reviewing-your-security-log/

mfuentesg commented 5 years ago

Hey guys, I have fixed that bug here

I am preparing a new release, with a lot of fixes and improvements.

I hope, next week publish a new release.

mfuentesg commented 5 years ago

Fixed https://github.com/mfuentesg/SyncSettings/pull/107