search

mful / notebook

0 stars 0 forks source link

Annotations sticking without Login or Submission #5

Closed anhtontran closed 9 years ago

anhtontran commented 9 years ago

I highlighted a piece of text before logging in or writing/submitting an annotation. When I closed the sidebar, the highlight remained on the page. I then went to highlight another area and clicked the "+" button and the sidebar did not pop-up and the highlight new highlighted stayed there as well as the previous one.

Replicated this issue twice.

screen shot 2015-02-17 at 8 39 01 pm

mful commented 9 years ago

I believe this is fixed by https://github.com/scribblely/crayon/commit/626c8771708543896340a8ff9d8f476b704f1c1c

At least, if I am understanding the steps, I am not longer able to reproduce it. Will review this evening.

mful commented 9 years ago

Marking as resolved.