search

mfumagalli / ImaGene

Estimation of population genetic parameters using deep learning
GNU General Public License v3.0
26 stars 10 forks source link

Fix hardcoded absolute paths in notebook and param files #3

Closed mathemage closed 4 years ago

mathemage commented 4 years ago

[...] @mfumagalli please don't hardcode absolute paths/names/settings that would work only on your computer.

Specifically, I have to change /home/mfumagal/... paths everywhere every time. It is troubling for me and I believe it must be terribly frustrating for non-expert users. I would suggest at least to extract a path variable that can set/changed at the beginning of the notebook.

Notebooks should be runnable for anyone just as is and that way they should be provided by us.

Originally posted by @mathemage in https://github.com/mfumagalli/ImaGene/issues/2#issuecomment-600814872

mathemage commented 4 years ago

ImaGene_iss_3

mfumagalli commented 4 years ago

I'd rather not accepting this change but keep it as it is so that users can set the paths in the parameters file along all other variables that need to be set.