search

mfussenegger / nvim-dap

Debug Adapter Protocol client implementation for Neovim
GNU General Public License v3.0
5.17k stars 180 forks source link

Update "Server rejected breakpoint" text #1007

Closed DanTup closed 8 months ago

DanTup commented 11 months ago

Problem Statement

Currently if a debug adapter returns verified: false for a breakpoint, "Server rejected breakpoint" is logged:

https://github.com/mfussenegger/nvim-dap/blob/1c63f37f95cd4fb54512898168138d9a75d1516a/lua/dap/session.lua#L887-L888

Using verified: false doesn't necessarily mean the breakpoint was rejected, it might just not be resolved yet. I've asked for clarification in the spec at https://github.com/microsoft/debug-adapter-protocol/issues/425.

It would be nice to update (or remove) this logging, because it can be confusing as-is. I had a query from a user asking why the debug adapter was "rejecting" breakpoints, but that's not really what's happening.

Thanks!

Possible Solutions

  1. Remove the logging
  2. Change the wording to say "Breakpoint is unverified"

Considered Alternatives

No response