mfussenegger / nvim-dap

Debug Adapter Protocol client implementation for Neovim
GNU General Public License v3.0
5.46k stars 194 forks source link

Hover evaluates the expression with `context = 'repl'` instead of `hover` #1107

Closed aikixd closed 10 months ago

aikixd commented 10 months ago

Debug adapter definition and debug configuration

Any config. I've discovered it with rust-tools using lldb. The issue is that the evaluation is called with context = 'repl' here, invoked here, through the widget It should be called with 'hover' as stated in the spec

Debug adapter version

No response

Steps to Reproduce

  1. Pause somewhere
  2. Use require('dap.ui.widgets').hover()

Expected Result

A hover window with the evaluation result.

Actual Result

The float contains Cannot evaluate "xxx"!

mfussenegger commented 10 months ago

Changed it in https://github.com/mfussenegger/nvim-dap/pull/1108, but from what I can tell the evaluation should've worked with repl as well and in my tests it worked with both codelldb and lldb-dap

aikixd commented 10 months ago

Much love!