search

mfussenegger / nvim-dap

Debug Adapter Protocol client implementation for Neovim
GNU General Public License v3.0
5.11k stars 179 forks source link

Prioritize local debugging method #1124

Closed TroySigX closed 3 months ago

TroySigX commented 6 months ago

load_launchjs is usually called after setting up dap.configurations, this leads to the local settings being put at the bottom of the methods selection list. But most of the time, user would prefer it to be at the top for convenience.

mfussenegger commented 5 months ago

Thanks for the PR.

One downside of this PR is that users could no longer get the old behavior back if they wanted to.

On the other hand, without this PR it's possible to call load_launchjs before adding manual dap.configuration entries to get this new behavior.

Because of that I'd keep this open a while longer to get some more comments / votes. Currently I'd tend towards not merging this change.

mfussenegger commented 3 months ago

Didn't gain any votes so I'm closing this.