mfussenegger / nvim-dap

Debug Adapter Protocol client implementation for Neovim
GNU General Public License v3.0
5.1k stars 179 forks source link

feat(utils): Implement pick_files() #1190

Closed cryptomilk closed 1 month ago

cryptomilk commented 2 months ago

This implements a file picker, to pick the file you want to execute with the debugger.

Fixes #1130

cryptomilk commented 2 months ago

It looks like this with telescope dap:

image

cryptomilk commented 2 months ago

Ping?

mfussenegger commented 1 month ago

Pushed a couple of changes:

Open questions to me:

cryptomilk commented 1 month ago

A fallback for nvim 0.10 would be nice as it just has been released :-)

mfussenegger commented 1 month ago

A fallback for nvim 0.10 would be nice as it just has been released :-)

Ah, I got the numbers mixed. It requires 0.10. The fallback would make it work in 0.9 or earlier.

cryptomilk commented 1 month ago

Ah, I got the numbers mixed. It requires 0.10. The fallback would make it work in 0.9 or earlier.

Ah, then I would argue new feature new nvim version required :-)

mfussenegger commented 1 month ago

Decided to add in the find fallback (but left bfs out). I also changed the result to return dap.ABORT, so it doesn't attempt to start the debug session if one cancels the dialog.