search

mfussenegger / nvim-jdtls

Extensions for the built-in LSP support in Neovim for eclipse.jdt.ls
GNU General Public License v3.0
1.09k stars 62 forks source link

Support change signature refactoring #464

Closed gbroques closed 1 year ago

gbroques commented 1 year ago

Problem Statement

I'd like LSP support when refactoring the signature of existing methods.

vscode-java and the Eclipse JDT LS recently added support for this:

Thank you, let me know if you have any thoughts! :)

Ideas or possible solutions

No response

mfussenegger commented 1 year ago

See https://github.com/mfussenegger/nvim-jdtls/pull/444

gbroques commented 1 year ago

See #444

Thank you for the fast reply, and work on this great plugin @mfussenegger! :)

Is it worth documenting this in the README?

I didn't realize support for this feature was already complete.

Also a demo GIF / mp4 showcasing this functionality would be fantastic!

Thank you again for the work on this plugin.

mfussenegger commented 1 year ago

https://github.com/eclipse/eclipse.jdt.ls/pull/2598

Done in https://github.com/mfussenegger/nvim-jdtls/commit/aa04fc0e4d8acbfa43efc6a6f7162b01987257a1

Also a demo GIF / mp4 showcasing this functionality would be fantastic!

The linked PR contains one.

gbroques commented 1 year ago

Thanks @mfussenegger! I appreciate this. :)