Show Junit test failures as ERROR diagnostics

mfussenegger / nvim-jdtls

Extensions for the built-in LSP support in Neovim for eclipse.jdt.ls

GNU General Public License v3.0

1.08k stars 62 forks source link

Show Junit test failures as ERROR diagnostics #665

Closed vishal423 closed 2 months ago

vishal423 commented 3 months ago

Closes #664

Test failures

Class initialization failure

Success scenario

Edit: Screenshots updated to display failure cause as error diagnostics

vishal423 commented 3 months ago

@mfussenegger, Is this something that you would consider for review? Otherwise, I can close the issue and PR. Thanks

tleonardi commented 3 months ago

@mfussenegger I think this PR adds great functionality! I don't know much Lua so can't fully review the PR myself, but I've been using this branch for two weeks with no issues at all. @vishal423, I've left a couple of comments based on my usage. @mfussenegger thanks a lot for this incredibly useful package! @vishal423, thanks for the PR, this addition make my experience a lot nicer!

vishal423 commented 3 months ago

@tleonardi, Glad! You liked the change. Irrespective of whether it gets merged over here, the change will reside on my fork as I need it for my day-to-day work. On a side note, I don't see your comments :)

tleonardi commented 2 months ago

@vishal423, the comments should now be visible. Thanks!