search

mfussenegger / nvim-lint

An asynchronous linter plugin for Neovim complementary to the built-in Language Server Protocol support.
GNU General Public License v3.0
2.03k stars 209 forks source link

fix(sqlfluff): Disambiguate sqlfluff diagnostics #642

Closed LJFRIESE closed 2 months ago

LJFRIESE commented 3 months ago

Sqlfluff does not provide severity codes in its messages. The original defaulted everything to ERROR. This change downgrades regular messages to WARN and only flags the code for a parsing error as ERROR. This is done because Sqlfluff formatting will fail if a parsing error occurs, and identifying the error is much easier when a distinction is made between errors and warnings.

LJFRIESE commented 2 months ago

Tests should pass now. They don't address the parse-failure that this change is disambiguating, but I'd rather not rewrite the whole test...