search

mfuu / vue3-virtual-drag-list

A virtual scrolling list component that can be sorted by dragging, for vue3
https://mfuu.github.io/vue3-virtual-drag-list/
MIT License
38 stars 11 forks source link

Fix reactivity of sortable and virtual props #17

Closed jaca1119 closed 7 months ago

jaca1119 commented 7 months ago

Hi, thx for your work! I noticed that some props were not updating when I changed them e.g.

const isDisabled = ref(false)
....
//somewhere else
isDisabled.value = true
...
<VirtualDragList :disabled="isDisabled"></VirtualDragList>

This change seem to fix reactivity of props. I tested it locally and it works but I didn't tested if some other parts are affected.

Also, when I build it on my local machine there is some change in types file IDK why

mfuu commented 7 months ago

Please pull the latest code and integrate it into a commit. Thank you for your PR.

jaca1119 commented 7 months ago

@mfuu done with build, but I don't know if I should have build it or not

mfuu commented 7 months ago

@mfuu done with build, but I don't know if I should have build it or not

Please merge the commits into one, and don't need to build. Thanks.

jaca1119 commented 7 months ago

@mfuu Done, also I reverted build because I was not sure if I should upload it