mfvanek / pg-index-health

pg-index-health is a Java library for analyzing and maintaining indexes and tables health in Postgresql databases.
Apache License 2.0
124 stars 14 forks source link

find a way to reduce amount of boilerplate code in tests #411

Closed BLoHny closed 3 months ago

BLoHny commented 3 months ago

relates https://github.com/mfvanek/pg-index-health/issues/375

mfvanek commented 3 months ago

@BLoHny Clone https://github.com/mfvanek/pg-index-health Then create a branch. Other maintainers (primarily me) will be able to add commits to this branch.

mfvanek commented 3 months ago

@BLoHny Clone https://github.com/mfvanek/pg-index-health Then create a branch. Other maintainers (primarily me) will be able to add commits to this branch.

@BLoHny See how to add another remote https://docs.github.com/en/get-started/getting-started-with-git/managing-remote-repositories

mfvanek commented 3 months ago

@mfaulther please take a look at this PR

BLoHny commented 3 months ago

I have a question. In two specific tests, the following error occurs: Container startup failed for image docker.io/bitnami/postgresql-repmgr:16.2.0. The docker image for that tag does not exist? It's been quite long time after the error occured

mfvanek commented 3 months ago

I have a question. In two specific tests, the following error occurs: Container startup failed for image docker.io/bitnami/postgresql-repmgr:16.2.0. The docker image for that tag does not exist? It's been quite long time after the error occured

Try to pull image manually https://hub.docker.com/layers/bitnami/postgresql-repmgr/16.2.0/images/sha256-49592c2cd1473011e63581090e3fbdb7aedb1a537579c024ea70f43aa76be39e?context=explore

BLoHny commented 3 months ago

We will close this pull request to create a pull request to a new branch.