search

mg2connext / connext

6 stars 0 forks source link

localStorage shim is causing issues with IE11 #15

Closed zenparsing closed 7 years ago

zenparsing commented 7 years ago

We're seeing severe issues with our website in IE when it loads Connext.min.js.

Connext.min.js contains the following code:

n = localStorage.removeItem;
localStorage.removeItem = function () {
  n.apply(this, arguments)
};

In IE11, this causes localStorage.removeItem to be set to a string value. Our website code is throwing exceptions in IE when it attempts to interact with local storage.

Please do not overwrite or attempt to shim window.localStorage. Otherwise, we will not be able to deploy this code.

sframe commented 7 years ago

Hey @mg2dael, can you give some feedback on this issue? It's affecting our Member Center work.

Thanks!

mg2dael commented 7 years ago

@sframe I've asked the devs to look into it during their morning tomorrow. @NatalliaMikhailava can you please make sure they know this is high priority?

sframe commented 7 years ago

Thanks ^_^

mg2dael commented 7 years ago

@sframe and @zenparsing We've got it fixed. The team is working on populating it into all our environments in Azure. At the latest you should see the fix tomorrow.