Open fpytloun opened 9 years ago
Hello Filip, thank you very much for your interest in Waliki!
I agree with you about the limitations of the way we are using git, specially in the impact on performance and the "bootleneck" for concurrency it means. undoubtedly, this should be migrated to libgit2 in the future.
for this problem in particular, I'd be glad with a pull request. Both ways you propose are ok (your choice) but if it the former, take care to be compatible with the wider range of git versions possible.
cheers!
If I call webhook via
curl -X POST http://waliki.ifrit.eu/wiki/_hooks/pull/origin
it get's stucked and will timeout.If run manually as given user, I get following:
IMHO working with git should be done some better way than calling subprocess or this issue should be solved by
-o StrictHostKeyChecking=no
or callingssh-keyscan
and adding remote host before pulling. Or at least mention this in docs (I am going to write a blog post about seting up and using Waliki soon).