mgaitan / waliki

A wiki engine powered by Django and Git
http://waliki.pythonanywhere.com
BSD 3-Clause "New" or "Revised" License
309 stars 56 forks source link

Run more commands with output to pipe instead of virtual terminal. #115

Closed OlegGirko closed 8 years ago

OlegGirko commented 9 years ago

This change makes all remaining (hopefully) commands invoked using sh module run with output to a pipe.

Default SELinux policy (at least, on Fedora) doesn't allow processes running from Apache HTTP server to create virtual terminals.

By default, sh Python module runs processes with output to virtual terminal. This is not needed for git and other commands, so it's better to explicitly make them write their output to a pipe instead of virtual terminal.

OlegGirko commented 8 years ago

Please ignore build errors with PyPy, they are not related to my changes.

mgaitan commented 8 years ago

thanks Oleg