mgaitan / waliki

A wiki engine powered by Django and Git
http://waliki.pythonanywhere.com
BSD 3-Clause "New" or "Revised" License
309 stars 56 forks source link

patterns are depricated in Django 1.10 #126

Closed dinya closed 7 years ago

dinya commented 7 years ago

urls.py

from django.conf.urls import patterns, url, include

falls with

...
  File "/opt/waliki/.venv/lib/python3.4/site-packages/waliki/urls.py", line 1, in <module>
    from django.conf.urls import patterns, url, include
ImportError: cannot import name 'patterns'

See https://github.com/mgaitan/waliki/blob/bc3e508cb7315cdf860780be7db128ee6f413049/waliki/urls.py#L1

See also http://stackoverflow.com/a/38799716/716469

mgaitan commented 7 years ago

thanks for the report. may you send a pull request for this?

On Fri, Sep 16, 2016 at 4:20 AM, Denis Sidorov notifications@github.com wrote:

urls.py

from django.conf.urls import patterns, url, include

falls with

... File "/opt/waliki/.venv/lib/python3.4/site-packages/waliki/urls.py", line 1, in from django.conf.urls import patterns, url, include ImportError: cannot import name 'patterns'

See https://github.com/mgaitan/waliki/blob/bc3e508cb7315cdf860780be7db128 ee6f413049/waliki/urls.py#L1

See also http://stackoverflow.com/a/38799716/716469

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mgaitan/waliki/issues/126, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPyB1Y7JoaIX6Vo3vaRbz-yCda1NTiZks5qqkNXgaJpZM4J-qJl .

mgaitan.github.io textosypretextos.com.ar

martibosch commented 7 years ago

I just sent a pull request with compatible urls for django 1.8, 1.9 and 1.10 https://github.com/mgaitan/waliki/pull/131