Fixes for new markups and Django

OlegGirko commented 7 years ago

This pull request contains changes needed for Waliki to pass all tests with Django 1.9 and markups 2.0.

Provide strip=False to PageForm's raw field for Django >= 1.9.
Use markdown's toc extension instead of deprecated headerid.
Move setting markdown extensions and output format to the method that creates Markdown instance.
Pass additional parameters to ReStructuredTextMarkup the way that works in markdown 2.0.

These changes were tested with:

Django 1.8.15 and markups 1.0.1 with Python 2.7.11 and 3.4.2.
Django 1.9.12 and markups 2.0.0 with Python 2.7.12 and 3.5.2.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 70.938% when pulling 0c6bb535d1bd3257171c962055e01b5537a02c45 on OlegGirko:fixes_for_new_markups_and_django into 0fb58dabbe5f14556febdd6629651db12372d2f3 on mgaitan:master.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 70.938% when pulling 0c6bb535d1bd3257171c962055e01b5537a02c45 on OlegGirko:fixes_for_new_markups_and_django into 0fb58dabbe5f14556febdd6629651db12372d2f3 on mgaitan:master.

OlegGirko commented 7 years ago

Test with Django 1.9.6 and Python 3.3 failed because Django 1.9 requires at least Python 3.4. I think, this test should be removed. All remaining tests succeeded.

mgaitan commented 7 years ago

@OlegGirko thank you so much for this work. I'll test it on the weekend, and then merge it, for sure. Waliki deserves much more love that I'm able to give now, and to have this kind of contributions make me very happy.

OlegGirko commented 7 years ago

@mgaitan, I use Waliki for ldbox project site, so I had to make all these changes to make it work with newer Fedora (24 and 25).

Also, I've packaged Waliki for Fedora (along with all necessary dependencies).

To make packaging easier, could you please tag new version (either 0.6.1 or 0.7) when you merge my changes? The way I package depends on version tags (actually, download URL in spec file depends on that), so source package contains tarball corresponding to latest version and patches applied to it. Having many patches applied to latest version is inconvenient.

OlegGirko commented 7 years ago

@mgaitan, Thank you for merging my changes and tagging a new version. I've built Fedora packages for version 0.7 successfully.

mgaitan commented 7 years ago

great, thanks to you!

mgaitan / waliki

Fixes for new markups and Django #129