search

mgaitan / waliki

A wiki engine powered by Django and Git
http://waliki.pythonanywhere.com
BSD 3-Clause "New" or "Revised" License
309 stars 56 forks source link

Drop bundled rst2html5; use package instead. #143

Closed wagnerflo closed 7 years ago

wagnerflo commented 7 years ago

While looking for another issue (more on that later) I noticed that there is a version of rst2html5 bundled as well as a dependency on the package. Use of the later is nowhere to be found in the code...

Quickly replacing the import in waliki/settings.py with from rst2html5_ import HTML5Writer seems to make it working perfectly.

The current version of the package produces output with one less newline, so I've changed the tests to accommodate that.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+3.6%) to 74.766% when pulling b2901f04791c311d78760b6c9b85e1410d579065 on wagnerflo:rst2html5 into 8358391700909056ef994e8e35ecc2ec552bba31 on mgaitan:master.

wagnerflo commented 7 years ago

If you decide to merge #144 then this commit here is included and could be discarded.