Reimplement Autolinks using only docutils features

wagnerflo commented 7 years ago

Currently the restructuredText markup implements Autolinks by parsing and modifiying the generated HTML. This implementation is...

Unnecessarily complex: The same functionality can be implemented with a modified docutils Writer class only. This allows dropping the dependency on pyquery and is surly much more efficient.
Buggy:
1. Indirect links don't work at all.
2. A comment in the code promises that embedded URIs would also be turned into links to the wiki. This also doesn't work and - by my understanding of the specs - should only work in the case of the embedded URI being a internal target. As in:
```
`long text <meep_>`_

.. _meep: link_
```

This implementation fixes all these problems which should be made clear by the tests I've added. It is based heavily on code from MoinMoin.

It includes the commit from #143 dropping the bundled rst2html5.py since the WalikiHTML5Writer class derives from the external package's HTML5Writer.

coveralls commented 7 years ago

Coverage increased (+3.8%) to 75.0% when pulling 1692fe4f8b8c1ed2cee2a7d7a98f10bd896d4760 on wagnerflo:autolinks into 8358391700909056ef994e8e35ecc2ec552bba31 on mgaitan:master.

mgaitan commented 7 years ago

this is brilliant. thank you so much. @wagnerflo please, feel free to add yourself to the list of contributors, and tell me if you are planning more improvements. I would like to release a new version when you consider appropriate.

In the other hand, one issue that would be nice to fix in the next release (particularly important for deployments with medium-high load like http://python.org.ar) is #134. I wonder if you may be interested in looking at it.

wagnerflo commented 7 years ago

As far as necessary to get the project I'm using Waliki in to a finished state I will continue contributing. Starting next week the frequency will probably drop quite a bit as other tasks will have to take priority.

For a decision when to do a release I currently have no opinion, but I do have a few functions to complete and test for my project that might turn up points of improvement or bugs.

I'll see about #134. That seems to be quite important and not very hard.

mgaitan / waliki

Reimplement Autolinks using only docutils features #144