search

mgaitan / waliki

A wiki engine powered by Django and Git
http://waliki.pythonanywhere.com
BSD 3-Clause "New" or "Revised" License
309 stars 56 forks source link

Fix breadcrumb links and improve their titles #145

Closed wagnerflo closed 6 years ago

wagnerflo commented 7 years ago

While moving the breadcrumb generation into a template tag, I failed to notice that the links generated therein are actually wrong.

Here's a fix that also improves titles: Previously breadcrumbs for pages that existed but didn't have a title set did get an empty string and thus an empty entry in the breadcrumb list. Now they'll be given the slug-part.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 75.154% when pulling 6cc74d795420a806d5bf64570c8ea2199afdabcb on wagnerflo:breadcrumbs into b7db696075ceebb5676be61f44e2d806cc472255 on mgaitan:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 75.154% when pulling 6cc74d795420a806d5bf64570c8ea2199afdabcb on wagnerflo:breadcrumbs into b7db696075ceebb5676be61f44e2d806cc472255 on mgaitan:master.

wagnerflo commented 7 years ago

Actually: What the breadcrumb code is doing, is making design decisions (what text to display for the link) in the code instead of the templates.

Please hold of merging this one. I'll amend the pull request and fix this in a (IMHO) better way.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.8%) to 75.771% when pulling 1c064c7b27fdc6fe72a56163354d7e894b0d7e1f on wagnerflo:breadcrumbs into b7db696075ceebb5676be61f44e2d806cc472255 on mgaitan:master.