mgalardini / pyseer

SEER, reimplemented in python 🐍🔮
http://pyseer.readthedocs.io
Apache License 2.0
109 stars 27 forks source link

pytest :test_load_structure fails #191

Closed linaule closed 2 years ago

linaule commented 2 years ago

Hi! I have installed pyseer through cloning the git repository and now am running a pytest. However, the test_load_structure keeps on failing. Here are my error messages:

tests/input_test.py::TestLoadFunctions::test_load_structure FAILED

tests/input_test.py:77

E TypeError: init() takes from 1 to 2 positional arguments but 3 positional arguments (and 3 keyword-only arguments) were given

pyseer/input.py:116: TypeError

What could have gone wrong?

johnlees commented 2 years ago

This is due to this line I believe: https://github.com/mgalardini/pyseer/blob/33e8e4fdde281dbec7bc3be93bced412efbec5c4/pyseer/input.py#L116-L118

I think scikit-learn may have changed its API recently: https://scikit-learn.org/stable/modules/generated/sklearn.manifold.MDS.html

So this would need to become:

        mds = manifold.MDS(n_components=max_dimensions, metric=metric_mds, n_jobs=n_cpus,
                           dissimilarity='precomputed',
                           random_state=seed)

Can you confirm which version of sklearn you are using? (conda list or similar)