mgalardini / pyseer

SEER, reimplemented in python 🐍🔮
http://pyseer.readthedocs.io
Apache License 2.0
104 stars 25 forks source link

Do the tree for calculating the kinship matrix should be rooted? #226

Closed Tonny-zhou closed 1 year ago

Tonny-zhou commented 1 year ago

Dear author,

Thank you very much for this GWAS tool! I have a small question, i.e., the core-genome phylogenetic tree used for calculating the kinship matrix (by the phylogeny_distance.py script) should be previously rooted (midpointed rooted or using outgroup etc.)? or we could use the unroot tree to calculate the kinship matrix?

Yours, Trump

johnlees commented 1 year ago

I usually midpoint root it (there's an option in the script for this), but it will depend on your dataset. Have a look at the QQ plot to confirm control is as expected