mgalgs / gnome-shell-system-monitor-applet

Display system informations in gnome shell status bar, such as memory usage, cpu usage, network rates…
https://extensions.gnome.org/extension/3010/system-monitor-next/
GNU General Public License v3.0
220 stars 19 forks source link

Support gnome-system-monitor 46 #62

Closed toupeira closed 8 months ago

toupeira commented 9 months ago

The launcher filename has changed in GNOME 46.

Also drops the unused extensions app lookup.


This change is Reviewable

toupeira commented 8 months ago

Thanks for the PR! Can you please share details about how this was tested (which GS versions you tested on, etc)?

Sorry I should have provided some context! :grinning:

I'm on Debian unstable which currently has a weird mix of packages, the update to Gnome 45 isn't fully finished yet but they also already pulled in some packages from Gnome 46 Beta where possible, especially standalone apps like gnome-system-monitor:

So I'm currently on gnome-shell 45.3-2 from experimental (unstable still has 44) and gnome-system-monitor 46~beta-1.

Don't we also need to add "46" to metadata.json?

I'll leave that up to you since I can't test it myself yet :wink:

It looks like some other changes are still needed: https://github.com/mgalgs/gnome-shell-system-monitor-applet/issues/61

NVieville commented 8 months ago

Hello,

Maybe the first line of the metadata.json file available here:

https://github.com/mgalgs/gnome-shell-system-monitor-applet/blob/master/system-monitor-next%40paradoxxx.zero.gmail.com/metadata.json

should be replaced from:

"shell-version": ["45"],

to:

"shell-version": ["45", "46"]

in order to reflect the gnome-shell 46 compatibility.

Feel free to make any comment about this subject.

Cordially,

-- NVieville

toupeira commented 8 months ago

@NVieville see https://github.com/mgalgs/gnome-shell-system-monitor-applet/issues/61 and my comment above https://github.com/mgalgs/gnome-shell-system-monitor-applet/pull/62#issuecomment-1965977127 :wink: