search

mgalushka / spymemcached

Automatically exported from code.google.com/p/spymemcached
0 stars 0 forks source link

MemcachedNodeROImpl accessor needs to be public #246

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
It is required for me to adjust the node locating function of spymemcached. One 
of its requirements is to implement the new NodeLocator similar to 
ArrayModNodeLocator. The getReadonlyCopy() of this class needs to create the 
new MemcachedNodeROImpl object. However, its accessor is default now and I 
can't use it outside the net.spy.memcached package.

Original issue reported on code.google.com by immxi...@gmail.com on 19 Apr 2012 at 11:51

GoogleCodeExporter commented 9 years ago 
What version are you on? In 2.8.1 getReadonlyCopy() is public is 
ArrayModNodeLocator and KetamaNodeLocator, but it is default in the 
NodeLocator. Seems like it's ok to make public in the interface. Is that what 
you need to get things working?

Original comment by mikewie...@gmail.com on 13 May 2012 at 5:26

GoogleCodeExporter commented 9 years ago 
No response for a few months here so I am closing this as invalid. Please 
reopen if you have interest in this issue and can provide a good reason why we 
should make this api public.

Original comment by mikewie...@gmail.com on 17 Aug 2012 at 5:47

GoogleCodeExporter commented 9 years ago 
You can reopen.
The guy was asking to have the class MemcachedNodeROImpl public (constructors 
are public, but not the class itself).

Since it isn't currently, it is impossible to write its own NodeLocator (in a 
different package than net.spy.memcached)... which requires getReadonlyCopy... 
which requires to create new instances of MemcachedNodeROImpl.

Original comment by fabienre...@gmail.com on 5 Feb 2014 at 6:54