search

mgaman / PDUlib

Encode/Decode PDU strings for use with most GSM modems. Both 7 bit and 16 bit alphabets are supported.
GNU Lesser General Public License v2.1
22 stars 10 forks source link

fix warnings in the esp-idf compilation #15

Closed merlokk closed 2 years ago

mgaman commented 2 years ago

Thanks for the input. I am going to adopt your suggestions in my next release but with 1 change pdulib.cpp line 231 set to -1. More correct handling of default case in line 259 switch statement

Re line 740: I didn't know that trick, so I learned something today. All my arduino testing was done on AVR so I didn't see the quirks of eps32/esp8266.

mgaman commented 2 years ago

In 0.5.4 compiling for AVR with VS code/PlatformIO results in no warnings. Other combinations such as AVR/Arduino IDE and ESP32 do shout warnings. I do not intend to invest any more time on this issue. Actual bugs will, of course, get fixed.