search

mgaman / PDUlib

Encode/Decode PDU strings for use with most GSM modems. Both 7 bit and 16 bit alphabets are supported.
GNU Lesser General Public License v2.1
22 stars 10 forks source link

All parts of a multipart encoded message are prepended with a space #36

Closed baskluiters closed 1 year ago

baskluiters commented 1 year ago

When encoding multipart messages, every part has a prepended space. Also when a multipart with 1 parts is encoded, the space is prepended. Verified on my smart phone by observing the received SMS Verified using the encoded string on https://www.smspdu.be; by viewing the HTML source you also see the prepended space

Using version 0.5.7 (also tested with 0.5.5: same result)

mgaman commented 1 year ago

Please send me the PDU strings

baskluiters commented 1 year ago

This is the PDU string of the string rabbit (without a leading space).

07911356000000F341000B911326000000F000000E0500032A010140F2B0589CA603

mgaman commented 1 year ago

Ok, I think I know where the problem is. I'm on vacation now, will check it in a couple of weeks.

On Sun, Jan 8, 2023, 11:23 Bas @.***> wrote:

This is the PDU string of the string rabbit (without a leading space).

07911356000000F341000B911326000000F000000E0500032A010140F2B0589CA603

— Reply to this email directly, view it on GitHub https://github.com/mgaman/PDUlib/issues/36#issuecomment-1374773609, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3KSTTWJ246PGMRPNTRIZLWRKBP7ANCNFSM6AAAAAATT6SRQA . You are receiving this because you commented.Message ID: @.***>

mgaman commented 1 year ago

I've just looked into this and I found that the bug occurs when sending a multi-part GSM7 bit message with a reference number < 255. A work around is to provide a reference number > 255. Please do this until I fix the bug.

baskluiters commented 1 year ago

Ok Thanks

Op 27 jan. 2023, om 11:01 heeft mgaman @.***> het volgende geschreven:

I've just looked into this and I found that the bug occurs when sending a multi-part GSM7 bit message with a reference number < 255. A work around is to provide a reference number > 255. Please do this until I fix the bug.

— Reply to this email directly, view it on GitHub https://github.com/mgaman/PDUlib/issues/36#issuecomment-1406278208, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASXHLTUYCBCM7PN6FLWC5PLWUOMITANCNFSM6AAAAAATT6SRQA. You are receiving this because you authored the thread.

mgaman commented 1 year ago

Fixed in release 0.5.9