mgansler / mscgen

Automatically exported from code.google.com/p/mscgen
GNU General Public License v2.0
1 stars 0 forks source link

Mscgen.exe hangs #32

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Input more than 1308 Arcs in MSC file
2. Open cmd prompt and run "mscgen.exe -T png test.msc"
3.

What is the expected output? What do you see instead?
Expected mscgen to return to command prompt and png file to be created
Observe that mscgen doesnt return back to cmd prompt.

What version of the product are you using? On what operating system?
0.17 W32

Please provide any additional information below, including sample input
file:
LIBGD calls to draw Lines etc take int instead of unsigned int as input. 
So if the y value is exceeding 32767, calls into LIBGD dont return.

Original issue reported on code.google.com by amitmank...@gmail.com on 19 Oct 2009 at 1:26

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by Michael....@gmail.com on 19 Oct 2009 at 8:32

GoogleCodeExporter commented 8 years ago
Hmm, I am not magician enough to figure out how to make mscgen generate an 
image in
this case - probably it will not be possible unless we can use a different part 
of
libgd or libgd starts using unsigned integers.

But I believe we can at least make it fail "gracefully" in this case with an 
error
message; e.g. by type casting to signed int in gd_out.c, check against 0 and 
then
exit with message if that is the case.

~Niels

Original comment by NThykier@gmail.com on 1 Nov 2009 at 11:04

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r106.

Original comment by Michael....@gmail.com on 3 Jan 2010 at 8:14

GoogleCodeExporter commented 8 years ago
I can't reproduce this, so I've added range checks before each call into libgd. 
 This
should avoid the possibility of mscgen hanging, and will produce clipped output 
instead.

Original comment by Michael....@gmail.com on 3 Jan 2010 at 8:16