mgba-emu / mgba

mGBA Game Boy Advance Emulator
https://mgba.io/
Mozilla Public License 2.0
5.59k stars 768 forks source link

Issue with sounds in Pokémon Crystal (ITA) #1178

Open Lorenzooone opened 5 years ago

Lorenzooone commented 5 years ago

Pichu's cry in Italian Pokémon Crystal (don't know if it's the same in English) has a lot of statics. I first noticed this while using mGBA on Switch, but the issue is there in the Windows version too.

I tested with BGB and it doesn't have sound issues.

Save file is attached.

Pokemon Cristallo (ITA)---Save.zip

profi200 commented 5 years ago

There are actually quite a few more Pokémon with off voice. It's a general issue.

endrift commented 5 years ago

I've fixed Pichu at least in 555122e0a1bc1311040e6ff7a8b2d95090fa76ca. Don't know which other ones are off.

Lorenzooone commented 5 years ago

I edited the save (below) to test the cries through the pokedex using the latest build on Windows (the one with fixed Pichu). Here's the results: Too much echo on Clefable Sandslash goes too low Dunsparce goes too low (after the high pitch) Too much echo on Ampharos Strange Wooper (Too low?) Gastly goes too low Strange Haunter (Too low? A lot) Strange Unown (Too low?) Steelix goes too low Politoed goes too low Oddish goes too low Gloom has something... Vileplume goes too low Strange Bellossom Hypno goes too low Kadabra goes too low (last part) Pineco goes too low Forretress goes too low Strange Yanma (echo? Low? Seems both) Exeggutor goes too low Sudowoodo goes too low Strange Scizor Heracross goes too low Magnemite is weird. Whole sound is missing Magneton is weird. Low and echo-y Electrode goes too low Arcanine goes too low Stantler goes too low Too much echo on Marril... ? Azumarill goes too low Diglett is missing a part of the cry (Similar to Magnemite) Strange Mankey Persian is either too low or some sounds are missing Strange Psyduck Strange Golduck Tyrogue goes too low Strange Hitmonlee Smoochum goes too low Electabuzz goes too low Farfetch'd has a weird High pitch Qwilfish goes too low Tentacool goes... Too low? A part seems to be missing Tentacruel goes too low Corsola has a weird echo in the last part Lickitung is weird Tangela is weird Eevee goes too low Vaporeon is weird. Strange echoes Horsea goes too low Ursaring goes too low Skarmory isn't... Sharp enough? Doduo is weird. Part of the cry is missing (Similar to Magnemite) Dodrio is strange... Maybe too low? Seems short Kangaskhan is too clean Rhyhorn is too clean Houndoom goes too low Porygon is... too low? Strange Porygon 2 goes too low Chansey's missing a bit of a high pitch Blissey's missing a bit of a high pitch Lapras is either too low or too clean Kabuto is missing a part of the cry Aerodactyl goes too low and has a wrong high pitch Wartortle is too clean Blastoise goes too low Articuno is missing some echo Larvitar has a tiny piece that goes too low near the end Tyranitar is too clean Lugia goes too low Ho-Oh goes too low Mew goes too low Celebi goes too low

Pokemon - Crystal Version (UE) (V1.1) [C][!].zip

endrift commented 5 years ago

Yikes that's a big list. Given the types of changes I needed to do for Pichu I'm going to push this to 0.7.0.

endrift commented 5 years ago

Pushed another fix, please retest all of those when you have time. I will try to fix more in the meantime. (This fix I know fixes Magnemite, Diglett, and I think Doduo, and may fix more.)

Lorenzooone commented 5 years ago

Updated list: Too much echo on Clefable Sandslash goes too low Dunsparce goes too low (after the high pitch) Too much echo on Ampharos Strange Wooper (Too low?) Gastly goes too low Strange Haunter (Too low? A lot) Strange Unown (Too low?) Steelix goes too low Politoed goes too low Oddish goes too low Gloom goes too low. Was worse Vileplume goes too low Bellossom has too much echo and goes too low. Was worse Hypno goes too low Alakazam goes too low Pineco goes too low Forretress goes too low Strange Yanma (echo? Low? Seems both) Exeggutor goes too low Sudowoodo goes too low or the echo makes it seem like that Scizor goes too low. Was worse Heracross goes too low Magnemite goes too low. Was worse Magneton is weird. Low and echo-y Stantler goes too low Too much echo on Marril... ? Azumarill goes too low Diglett has echo. Was worse Mankey goes too low. Was worse Persian goes too low. Was worse Psyduck goes too low and has echo. Was worse Golduck has echo. Was worse Hitmonlee goes too low and has echo. Was worse Electabuzz goes too low Farfetch'd has a weird High pitch Tentacool goes too low. Was worse Tentacruel goes too low Corsola goes too low. Was worse Lickitung goes too low. Was worse Tangela has echo. Was worse Eevee goes too low Vaporeon is weird. Strange echoes that go too low. Was worse Horsea goes too low Skarmory goes too low. Was worse Doduo has a high pitch. Was worse Dodrio goes too low. Was worse Houndoom goes too low. Was worse Porygon has echo. Was worse Porygon 2 goes too low. Was worse Chansey goes too low. Was worse Kabuto 's high pitch has echo. Was worse Aerodactyl goes too low and has a wrong high pitch. Was worse Lugia goes too low Mewtwo goes too low Mew goes too low

Thanks to that, a few got fixed, so here's the new list. Some are now identified and not just "strange".

Good work!

BTW, the save uses Stereo setting for audio. I hope there's not an issue with that in particular.

endrift commented 5 years ago

Thanks for updating! I'm actually using a different save I already had, but it's also in stereo so that's not a problem.

endrift commented 2 years ago

Please retest in 76a8f4da2bb4fc4ef10a64eae5d3da0d7846c73f or newer.

Lorenzooone commented 2 years ago

Hello, I changed my setup from last time. Now I'm comparing mgba to a GB Player. All in all, I don't hear any big echo issues anymore, though it does seem like some sounds get clipped and result being lower than they should be. The usual suspects are still there, like Haunter and Magneton, but in general it's good. Most of these aren't easy to hear.

Meganium - Too soft in the first part...? Typhlosion - Spike is too low. Pikachu - Spike is too low. Raichu - Spike is too low. Metapod - Spike is too low. Geodude - Spike is too low. Golbat - Random extra spikes. Sandslash - Spike is too low. Ekans - Spike is too low. Arbok - Spike is too low. Dunsparce - Spike is too low. Ampharos - Spike is too low. Wooper - Spike is too low. Gastly - Spike is too low. Haunter - Random extra spikes. Very evident. Unown - Spike is too low. Onix - Spike is too low. Steelix - Spike is too low. Evident. Victribell - Spike is too low. Hoppip - Spike is too low. Paras - Spike is too low. Parasect - Spike is too low. Poliwrath - Echo isn't enough...? It's weird... May be a note being too low. Politoed - Echo isn't enough...? It's weird... May be a note being too low. Goldeen - Extra spike. Oddish - Spike is too low. Evident. Gloom - One note is off. Bellossom - Random extra spikes. Drowzee - One note is off. Hypno - Spike is too low. Abra - Spike is too low. Kadabra - Spike is too low. Evident. Alakazam - Spike is too low. Evident. Forretress - Spike is too low. NidoranF - Spike is too low. Nidorina - Spike is too low. Nidoqueen - Spike is too low. NidoranM - Spike is too low. Nidorino - Spike is too low. Nidoking - Spike is too low. Exeggcute - Spike is too low. Exeggutor - Spike is too low. Scizor - Spike is too low. Pinsir - Spike is too low. Heracross - Spike is too low. Koffing- Spike is too low. Magnemite - One note is off. Magneton - Notes are off. Very evident. Marill - Extra random spikes. Azumarill - Spike is too low. Diglett - One note is off. Dugtrio - One note is off. Mankey - Spike is too low. Persian - One note is off. Evident. Miltank - Spike is too low. Jinx - Spike is too low. Elekid - One note is off. Electabuzz - One note is off. Farfetch'd - Random extra spike. Tentacruel - One note is off. Staryu - Spike is too low. Starmie - Spike is too low. Corsola - One note is off. Lanturn - Spike is too low. Vaporeon - One note is off. Horsea - One note is off. Doduo - Extra random spike. Murkrow - One note is off. Houndoom - Spike is too low. Magcargo - Spike is too low. Porygon - Extra random spike + one note is off. Lapras - Spike is too low. Kabuto - One note is off. Kabutops - Final note is off. Aerodactyl - Extra random spikes. Articuno - Final note is off. Lugia - Spike is too low. Mew - Extra random spike.

endrift commented 2 years ago

I've updated a bunch of stuff, so this could use retesting when possible. Are these in Johto-dex order? It'd be nice to get them in a consistent order for retesting.

Lorenzooone commented 1 year ago

Hi! Sorry for the delay. The list is in Johto order.

There have been noticeable improvements. No more extra random notes/spikes, and the most problematic cases are both way better (with Haunter being fixed entirely).

Honestly, it's getting to the point that some of these could be chalked up to the audio equipment. (Not all of them, but some) It's way better than when this issue was first published.

Typhlosion - Spike is too low. Fearow - Mixing is different. Rattata - Mixing is different. Pikachu - Mixing is different. Caterpie - Mixing is different. Metapod - Mixing is different. Geodude - Spike is too low. Graveler - Spike is too low. Crobat - Spike is too low. Sandslash - Spike is too low. Ekans - Mixing is different. Arbok - Mixing is different. Onix - Mixing is different. Steelix - Spike is too low. Parasect - Mixing is different. Poliwrath - Mixing is different. Politoed - Mixing is different. Hypno - Something feels off... But it's better. Kadabra - Spike is too low. Alakazam - Spike is too low. NidoranF - Spike is too low. Nidoqueen - Spike is too low. Pinsir - Mixing is different. Evident. Koffing - Spike is too low. Magnemite - Spike is too low. Evident. Magneton - Mixing is different. Way better. Granbull - Spike is too low. Mankey - Mixing is different. Tauros - Mixing is different. Miltank - Mixing is different. Electabuzz - Spike is too low. Evident. Tentacruel - Spike is too low. Evident. Corsola - Mixing is different. Zapdos - Mixing is different.

endrift commented 1 year ago

That's a much shorter list. Glad things are improving.