search

mgba-emu / mgba

mGBA Game Boy Advance Emulator
https://mgba.io/
Mozilla Public License 2.0
5.71k stars 789 forks source link

Square wave emulation issue #1657

Closed Yave-Yu closed 1 year ago

Yave-Yu commented 4 years ago

Hey, your mGBA is awesome, running fast, emulation speed is accurate, Wave(Ch3) and Noise(Ch4) are accurate to an actual hardware(or VC?), but square waves(Ch1&2) are not very accurate, it emulates lower quality than actual hardware(or VC). About SFX, my memoriable point are on any Pokemon game's selection sound, it sounds so broken; any Mega Man Battle Network game's jack in "Di" sound, it sounds on lower octave. About Music, the first game of Mega Man Battle Network series could be an example. Virus Busting and Fire Field are more obvious, it's square wave should be more smooth like actual hardware(or VC), not intermittent. Hope you can make square wave emulation more better~

Kaleidosium commented 4 years ago

Could you provide Waveforms of the Emulated one and Real Hardware?

endrift commented 4 years ago

Do you have any savegame in MMBN I can use to reproduce and compare this? This isn't much to go on, it's rather anecdotal. As far as I can tell the jack-in SFX doesn't even use the square wave.

Yave-Yu commented 4 years ago

Here's MMBN1 sav I've played to Fire Field: http://www.mediafire.com/file/ma4khwgdunhjutl/Mega_Man_Battle_Network_%2528USA%2529.sav/file And... I'm sorry, I have no real GBA, I just watch someone's playthrough video, he plays on VC, here's video link: http://www.nicovideo.jp/watch/sm15255402 Fire Field music: https://youtu.be/cplRj1b2b9c

And now I discover Wave(Ch3) emulation have a little issue too, Net Battle(Boss) music: https://youtu.be/AjYZ9MKSEi4 or this, someone's all Navi battle on VC: https://youtu.be/xvWPzPPdDu8 Listen to this song's intro carefully, latter Rockman EXE - Operate Shooting Star on DS could prove it. I'm sorry for I got wrong with that channel using of jack in sound, but in mGBA, it really lowered octave.

Another game, Mother 3, the bass wave of cast song's ending, in mGBA it sounds like NES's Triangle, but it should be another wave. You can check this video and listen to that cast song's ending: https://youtu.be/vr8tT8Q4R7U

About Square Wave, MMBN2 Title music is also a good example on square wave emulation test, check this video(Just hear its title song): https://youtu.be/rl5cQSpbNYI

About Pokemon's selection sound, I also just watch a VC video on SpeedDemosArchive. http://speeddemosarchive.com/PokemonFireLeaf.html

I hope you can make its emulation more accurate and mGBA will become an accuratest GBA emulator ^lol^.

Testsr commented 4 years ago

One thing. VC means to me Virtual Console, which is an Nintendo Emulator for older systems, and may not be able to be trusted.

Kirit29 commented 4 years ago

One thing. VC means to me Virtual Console, which is an Nintendo Emulator for older systems, and may not be able to be trusted.

VC, in the case of GBAVC, is not technically an emulator. It uses hardware that exists in an actual GBA to run games. It is close to 100 percent accurate. To the point where most issues that mgba has with my roms GBA vc has the same issue.

endrift commented 4 years ago

In this case it's Wii U VC, not 3DS VC, which is an emulator.

Kirit29 commented 4 years ago

Crap i forgot wiiu gba vc was a thing. Lol sorry.

endrift commented 2 years ago

Please retest in 76a8f4da2bb4fc4ef10a64eae5d3da0d7846c73f or newer.

endrift commented 1 year ago

Closing due to lack of reply.