mgba-emu / mgba

mGBA Game Boy Advance Emulator
https://mgba.io/
Mozilla Public License 2.0
5.68k stars 781 forks source link

Broken savegame screen on Mario & Luigi: Superstar Saga #1756

Closed renecatharsis closed 4 years ago

renecatharsis commented 4 years ago

The savegame screen on Mario & Luigi: Superstar Saga (tested the EU version) looks broken sometimes. Weirdly enough it doesn't happen all the time, but I can get it to look broken when resetting a few times.

Build used: mGBA-0.8.1-win64 with OpenGL renderer OS: Win10 Pro, 64-bit System specs: Core i7-8750H, GeForce GTX 1060

Broken screen: mlss-saves-broken

Correct screen: mlss-saves-correct

endrift commented 4 years ago

I think I've seen this in the US version too. Not sure why it's inconsistent though; every time I've tried to debug it it doesn't happen.

renecatharsis commented 4 years ago

Which OS are you trying to get it to break on? I could set up a quick VM with that and see if I can reproduce it there to maybe rule out OpenGL on Windows as the issue (unless it's *BSD which will leave me begging for mercy :) ).

RetroEdit commented 4 years ago

Also, if you can reproduce it, a savestate of when it's in the broken state might be somewhat helpful? At least it would confirm whether the issue is PC-specific or an actual emulation problem.

renecatharsis commented 4 years ago

While trying to reproduce I have noticed something curious. I had continued playing on my save since opening the issue and couldn't reproduce the error anymore. I could however reproduce again on a fresh savefile, while only having Mario as part of my team, Luigi is only still hanging around, not part of the actual battling team. As soon as Luigi joins, I cannot reproduce any more.

While messing around I even found another bug occuring on the save screen only. When I enter the "Mario Bros." mode on the start screen, exit out and then enter "Mario & Luigi" mode, it looks like the save game's behind prison bars. This bug I can reproduce consistently at any game state. mlss-saves-broken-mariobros

You can find savestates of all that attached.

mlss-states.zip

endrift commented 4 years ago

is that "mode" only in the OpenGL renderer too?

renecatharsis commented 4 years ago

Seems like it, couldn't force it to happen on Software Renderer at all.

endrift commented 4 years ago

Ok, I'll try to look into this tonight. Thanks for the savestates.