Using "Replace Rom..." resets game overrides

[camthesaxman]

Use Case: I am trying to use mGBA to test a multiboot program (one sent over the link cable) that reads data from an inserted Pokemon Emerald cartridge. The multiboot program needs to be able to read data from the cartridge ROM as well as save data from the cartridge, therefore it's essential that the Game Overrides persist after replacing the ROM.

Steps to reproduce:

• Open "Tools" -> "Game Overrides...".
• Change the Save Type to "Flash 1Mb".
• Click "Save".
• Start a ROM using "File" -> "Load ROM".
• Go to "File" -> "Replace Rom..." and select a ROM (it can even be the same one).
• Go to "Tools" -> "Game Overrides...".

Expected result:

• The Save Type is set to "Flash 1Mb".

Actual result:

• The Save Type has been reset to "Autodetect".

[endrift]

There are arguments for doing it both ways, so it should probably be an option. That said, Emerald should autodetect the overrides properly when you load it, so that's a separate issue here.

[camthesaxman]

That's fine. I'd be okay with it loading the settings for the cartridge that you swap to. It makes sense because with physical hardware, the save memory is located on the cartridge, so when you swap cartridges, you're swapping save memory.