search

mgba-emu / mgba

mGBA Game Boy Advance Emulator
https://mgba.io/
Mozilla Public License 2.0
5.76k stars 795 forks source link

Pokémon Emerald Audio Issue #1820

Closed ghost closed 4 years ago

ghost commented 4 years ago

Here's a YouTube video illustrating the audio issue.

The issue is only present on the FIFO Channel A and FIFO Channel B audio channels. The four PSG audio channels are fine.

This mostly only seems to be an issue in the opening scene with the professor. Doesn't really happen outside of that that I've noticed.

Additional info:

mGBA version: 0.8.2 PC specs: https://pcpartpicker.com/user/xnaas/saved/CTBWGX

FWIW, this same audio issue appears in ares and VBA-M as well.

endrift commented 4 years ago

Can you please explain the issue? I'm not sure I'm understanding exactly what the issue is.

ghost commented 4 years ago

Do you not hear the clicking in the background in the video?

endrift commented 4 years ago

My laptop is kind of quiet and it wasn't obvious. Have you confirmed that it doesn't happen on hardware?

ghost commented 4 years ago

Here's a second example with the PSG audio channels filtered out and only the FIFO audio channels present: youtube link

ghost commented 4 years ago

I don't hear the noise on my Game Boy Micro either through the speakers or with wired headphones plugged in.

Edit: At any volume level (quiet or maximum).

ghost commented 4 years ago

I don't know if an MVL is useful or not for audio, but...

emerald-video-debug-log.mvl.zip

endrift commented 4 years ago

No, mVLs are video only. I'll take a look sometime later. Not right now though.

ghost commented 4 years ago

Fair enough. I'm sure there's plenty of actually important things to look into lol

vaguerant commented 4 years ago

I was asked in IRC if I could record this on hardware to see whether it occurs there. Here's the resulting file as recorded from a DS Lite. I personally cannot hear the audio artifacts demonstrated in @xnaas's videos.

https://cdn.discordapp.com/attachments/424654243199320066/735020115598508072/PokemonEmerilBam.m4a

endrift commented 4 years ago

Either I'm deaf or I can't hear this on latest master. Can you retest this?

ghost commented 4 years ago

Even on 0.8.4 this sounds worlds better: Streamable video

Whatever changes happened between 0.8.2 and 0.8.4 must've been adequate. 😃