Non-English FireRed detected as ROM hack

mgba-emu / mgba

mGBA Game Boy Advance Emulator

https://mgba.io/

Mozilla Public License 2.0

5.67k stars 777 forks source link

Non-English FireRed detected as ROM hack #2100

Closed cruiseliu closed 3 years ago

cruiseliu commented 3 years ago

The commit "GBA: Fix FireRed revision misdetecting as a ROM hack" only checks CRC of English versions. mGBA sometimes creates invalid save file for Japanese FireRed. I can't always reproduce it, but I comment out relative lines in overrides.c and it never happens again.

endrift commented 3 years ago

Yes, I was made aware of this last night and I'm working on a fix.