search

mgba-emu / mgba

mGBA Game Boy Advance Emulator
https://mgba.io/
Mozilla Public License 2.0
5.75k stars 795 forks source link

[Libretro] Ability to adjust Solar Sensor levels #22

Closed Awakened0 closed 9 years ago

Awakened0 commented 9 years ago

Currently the Libretro port lacks any way to change the solor sensor level. I think it'd be best to map the increase and decrease functions to unused RetroPad buttons. L2 and R2 or L3 and R3 would work well. That way you could change the level easily during gameplay.

endrift commented 9 years ago

I'm not sure about that approach, but I do want to add some way of adjusting them.

Awakened0 commented 9 years ago

That'd be the only way to have a dedicated button and/or key for adjusting it. Some of the other cores map system functions to unused RetroPad buttons. For example, Desmume maps "blow in the mic" to L3 and the Nestopia core maps "flip disk" to L for Famicom Disk System games. Users can remap those functions using core remap or override files.

You could instead add a core option to adjust the solar level. It'd just be slightly more cumbersome, since a user would have to bring up the menu and navigate to Options, Core Options. That can all be done with a gamepad too, so it's not too bad.

You could probably implement both methods if you wanted.

endrift commented 9 years ago

I talked to some libretro devs about this a few hours ago and they said pretty much exactly the same thing. I'll probably do it that way, after all.

endrift commented 9 years ago

3a31577cab0794a929e738f02687c9fc4e40c46a adds support for the solar sensor, but there are no keybindings yet.

endrift commented 9 years ago

5a932631bee45043aabc0eda64858164b91c171e binds them to L3 and R3.

Awakened0 commented 9 years ago

Got a nightly build today to try this out. It works perfectly. Thanks!