search

mgba-emu / mgba

mGBA Game Boy Advance Emulator
https://mgba.io/
Mozilla Public License 2.0
5.47k stars 750 forks source link

[Feature Request] Mute when Rewinding/Switch Pro Controller Motion Controls on PC #2548

Open Mateo-Git opened 2 years ago

Mateo-Git commented 2 years ago

Hi, I love mGBA, it's an amazing really accurate emulator with a lot of awesome features and has certainly usurped VBA-M from its throne as the best GBA emulator. I love how it even supports Game Boy Player features such as rumble. I just have two requests that would make it even better:

My first request is simple: mGBA already has an option to mute the audio when fast forwarding, would it be possible to do the same when rewinding? Either via the same volume sliders or separate ones? Snes9X already does that and it's great, that way you can only hear the game's audio at its original speed all times if you wish.

My second request consists in bringing an already existing feature from the Nintendo Switch to PC: When using a Switch Pro Controller on PC, use its Motion Controls for controlling motion sensor cartridge games (such as Yoshi's Topsy-Turvy and WarioWare Twisted) on PC just like the Switch Port does.

Thank you for reading and for the amazing work on mGBA!

Mateo-Git commented 1 year ago

Hi again, to add on to this, I want to report something related that I recently noticed. When you use the rewind feature while using a controller with rumble, the rumble keeps happening while you are rewinding, while the intended behavior should be that no rumble should happen while rewinding (This happened to me while rewinding using the built-in Game Boy Player rumble feature of Super Mario Advance 4) It'd be great if you could fix this as well, Thank You.