search

mgba-emu / mgba

mGBA Game Boy Advance Emulator
https://mgba.io/
Mozilla Public License 2.0
5.72k stars 792 forks source link

Sprite Flicker: Mario and Luigi Superstar Saga #2623

Open LoneSolo opened 2 years ago

LoneSolo commented 2 years ago

Sprites and objects randomly flicker while playing Mario and Luigi Superstar Saga. I can get it to occur consistently during the first cutscene, and talking to certain characters in the prologue (first character that shows you action commands, many of the characters on browsers airship). This is occurring in windows 10,11 and the steam deck. bug.zip

LoneSolo commented 2 years ago

I did some additional testing and found out the reason its flickering has to do with the game boy player mode. Even though I had it turned off in settings it was still turned on through the game override modes. Its a shame it has to be turned off since this game uses rumble but it functions as expected now that the mode is turned off.

endrift commented 2 years ago

The game actually flickers on an real Game Boy Player. Though I'm not sure it flickers as much as it does in mGBA.

twoco commented 1 year ago

I can confirm on Miyoo Mini Plus. It‘s not due to transparency technique or etc. Also not on real GBA (not in this case). You can see e.g. in intro scene. The toads with trumpets flashing / glitches. No flashing with gpSP. Not sure, but I never have seen this before. I will test this on PC soon.

endrift commented 1 year ago

You don't need to do additional testing in emulators. mGBA will behave the same regardless of what platform it's running on, too.

twoco commented 1 year ago

I tested it now and nope. On PC it works well without any issues. The sprites do not flicker on PC.

Maybe it has to do with the display driver you can set on RetroArch? Miyoo Mini Plus has no screen recorder, but I could film with my smartphone. ^^ Or can we reproduce this on PC?

endrift commented 1 year ago

You linked to a commit that's almost a year old. That's your problem.

twoco commented 1 year ago

@endrift I tested the latest version 0.10.2 (Apr 24) now. Unfortunately the bug still exists. The sprites are still flickering.

perguto commented 4 months ago

@twoco It's not a bug, the game flickers intentionally because on the slow GBA LCD screen, this gives a transparency effect. To simulate this behavior in mgba, activate "Interframe Blending"

endrift commented 4 months ago

That is not correct for this game. Sprites absolutely do flicker incorrectly at times in M&L

twoco commented 4 months ago

In this case, the sprites are solid and no transparency effect intended. I'm on WIndows 11 and can't reproduce. In my case, it was only on a handheld (Miyoo Mni Plus). The thread author wrote Windows 10 and the attached files shows a good hardware. I have no idea if this is reproducable. In my case with the handheld, another emu like gpSP had no issues, no flickering. Not sure what the thing is. Maybe just a setting to tweak or a bug? idk Here is a video. Not perfect on video. It's better so see in RL. Maybe it helps.

!(video.webm)

endrift commented 4 months ago

That actually does happen, to some extent, on hardware if you're using a GB Player. If not, it doesn't.