search

mgba-emu / mgba

mGBA Game Boy Advance Emulator
https://mgba.io/
Mozilla Public License 2.0
5.38k stars 744 forks source link

PSG channels not fading correctly #3164

Closed brokenps2 closed 2 months ago

brokenps2 commented 2 months ago

When playing Super Mario Advance 4, I noticed that the PSG channels seem to not fade out and just continue playing at full volume as long as their duration is set for.

I'm using arch linux 6.7.6 & mGBA 0.10.3 SDL version.

endrift commented 2 months ago

Are there any tracks you can point to for comparison against, say, Game Boy Player footage? This is kind of vague.

brokenps2 commented 2 months ago

Yeah, it was most noticeable in the Mario Bros minigame, especially the coin falling sound (after enemy is killed)

This is what it sounds like for me This is a longplay of the the minigame, you can hear it at 0:43

endrift commented 2 months ago

Wow, That's definitely not happening for me in dev. Let me check 0.10.3.

endrift commented 2 months ago

Scratch that, it does happen in 0.10.3...in Super Mario Advance 4. I was trying a different version of the Mario Bros. minigame where it doesn't happen (in Mario & Luigi). I also confirmed that it works as expected on original hardware.

endrift commented 2 months ago

Regression from c8f4d4aad9c6d5f65589ff6c22592dee471a8ac4