search

mgba-emu / mgba

mGBA Game Boy Advance Emulator
https://mgba.io/
Mozilla Public License 2.0
5.38k stars 744 forks source link

SGB border visual glitch #3191

Open chiascuro opened 1 month ago

chiascuro commented 1 month ago

This was tested on mgba version 10.2, 10.3 and the latest development build (2024-04-17) Game: Pokémon Crystal Clear (Romhack) link: https://shockslayer.com/crystal-clear/ (I included the patch files in the zip) Patched here (official site) with SGB mode enabled https://inject.sigkill.tech/patch/cc Tried both, Version 1.0 and 1.1 of Pokémon Crystal as the base

Video of the issue/how to replicate it Basically, opening the Pokédex and closing it messes up the whole screen. Using the Pokédex, one can change the border color of the SGB Border (Cyan in the video), so it's probably just trying to update that. As seen in the video it can be fixed by switching party members as that also interacts with the SGB border.

This issue does not appear with the BGB emulator.

All other necessary information should be included in the automatically generated bug report zip file bug report.zip

endrift commented 1 month ago

I thought I fixed this one already...it keeps coming back.

endrift commented 1 week ago

I remember now. This is actually a bug in Crystal Clear. I'm pretty sure it was fixed at some point. I backed out the patch that fixed it (8a87eaa395ca4e84f8841ad8a2cd684d8a9f6c06) because it was clearly erroneous to include. It's not real hardware so there's no "well defined" way to do this, but it was special casing for one ROM hack so I didn't want to keep it. I guess bgb decided to leave that special casing in.

Please use an up-to-date version of Crystal Clear to confirm.

chiascuro commented 1 week ago

I tried it with the latest patch (2.5.10), I didn't find the files for 2.5.9 so I couldn't try it with the older one. I tried both, the normal version and the color filter version. I tried it on my current mgba installation and on the latest development build. The bug still persists

endrift commented 1 week ago

Hmm, alright, I'll take a closer look.

endrift commented 1 week ago

Reverting the reversion fixes it. Ugh. Looks like Crystal Clear still has the bug. I need to figure out if I work around their bug or pressure them to fix it instead.