mgballou / Someones-PC

The Best Pokemon Box system ever invented
0 stars 3 forks source link

Ciaran's Issue #2

Open kearmododragon opened 1 year ago

kearmododragon commented 1 year ago

Glow Snippet - One piece of code your team is especially proud of -

Ciaran -

function create(req, res) { if (req.body.name > 1008) { res.redirect('/pokemon/new') } let foundPokemon let randomInt = Math.floor(Math.random() * 10) if (typeof (req.body) !== Number) { endpoint = req.body.name.toLowerCase() } else { endpoint = req.body.name } axios.get(https://pokeapi.co/api/v2/pokemon/${endpoint}) .then(function (response) { foundPokemon = { name: response.data.name.toUpperCase(), dexNumber: response.data.id, user: req.user._id, sprite: response.data.sprites.front_default } if (randomInt === 1 && foundPokemon.dexNumber <= 905) { foundPokemon.sprite = response.data.sprites.front_shiny } Pokemon.create(foundPokemon) }) .then(function (newPokemon) { console.log(newPokemon) res.redirect('/pokemon') }) .catch(function (err) { console.log(err) res.redirect('/pokemon/new') }) }

Grow Snippet -

Ciaran- The piece of growth for the app that I'd have like would be the social aspect. The ability to share/trade/copy your pokemon to other users accounts.

Reflections -

a.What went well in building the project? What lessons will you take away from the experience?

Ciaran - collaboration aspect. I came away feeling that although I'd not written as much code myself, the collaboration aspect meant I didn't feel like I was dragging the team. Constantly navigating to offer ideas on the direction and wording of codes as well as suggesting ideas on the direction.

b.Is there anything about your efforts/workflow you want to reproduce in future projects?

Ciaran - Very open and honest conversation about what we're doing. We had a very clear plan moving forward into the project with our trello board and figma sheet. We were able to stick to those and stay focused. I ensured that I had both up at all times so that if we started to go off track I was able to bring us back towards that goal of MVP.

c.What did not go so well? Were there any events/obstacles that blocked you or impeded your team’s progress?

Ciaran - Due to my time restraints, I wasn't able to dedicate as much time to the project as my colleagues were. It's something that made me feel very guilty about falling behind. On top of this, there were times we seemed more focussed on stretch goals rather than hitting MVP so ultimately ended up covering some of them before we made it.

d.What will you do to prevent that from occurring in a future project/collaboration.

Ciaran- Allocate more specific time to the work. While now that's not possible I truly feel that in the future that will not be as much of an issue.

maker-jws commented 1 year ago

@kearmododragon

Great reflections Ciaran, the issue of time, especially working remotely and in different regions of the world is definitely a challenge, but doing your best to stay part of the discussion and supporting/guiding to the best of your abilities is a big growth opportunity and worth highlighting in future interviews/applications.