search

mgcrea / angular-strap

AngularJS 1.2+ native directives for Bootstrap 3.
mgcrea.github.io/angular-strap
MIT License
5.73k stars 1.38k forks source link

feat(popover): Add bsEnabled (data-bs-enabled in template) option #2156

Closed matthewdfleming closed 8 years ago

matthewdfleming commented 8 years ago

Presently the tooltip has bsEnabled support but no other components do. It is a handy feature. Please migrate it to the other components.

DaleWebb commented 8 years ago

Which components specifically?

As some of the components such as bsSelect attaches to a native HTML button, you can use the built-in attribute disabled="true" to the same effect - or ng-disabled

matthewdfleming commented 8 years ago

I was thinking loosely all of the visual window like components that extend from tooltip that are not currently disable-able.. i.e. modal, aside, popover, and possibly collapse.

DaleWebb commented 8 years ago

What would it mean to disable a modal, aside and popover? Those elements would be triggered by something else (e.g. timer, a button).

matthewdfleming commented 8 years ago

Same use case as the tooltip. You have the ability to define the tooltip in the partial, and the triggering of the visual is orthogonal to it being 'enabled' or not. So the trigger could be a mouseover but the enabling is dependent upon something else e.g. the user has more work to do in a section.

Edit: For instance, I added this feature to popover (via a decorator) so that a popover shows when a user mouseovers on an input field only when the field is in an error state after the form has been submitted once.

DaleWebb commented 8 years ago

Okay, that makes sense. I just found the PR that put in the feature so that I could see the conversation around it #1176.

Can you submit a PR for this?

matthewdfleming commented 8 years ago

I'll do a PR for each component.. that way we can make sure you like the change before going all in.

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.