search

mgcrea / angular-strap

AngularJS 1.2+ native directives for Bootstrap 3.
mgcrea.github.io/angular-strap
MIT License
5.73k stars 1.38k forks source link

508 Compliance Fixes #2218

Closed mikejr83 closed 7 years ago

mikejr83 commented 7 years ago

This PR comprises of fixes we've made to the source for 508 issues.

Our product is undergoing an intense 508 validation by TPG and these are some of the first fixes we've completed. We have more fixes incoming with a major push on the Calendar component.

mgcrea commented 7 years ago

Hi, Thanks for the PR and several fixes. Glad you are using this library in your product.

I will gladly merge your work as long at unit tests are kept green. Also new features should add relevant unit tests.

Finally, if you're willing to contribute significantly to this library either by maintaining it or adding new features, I could consider adding you as an official collaborator.

Thanks!

mikejr83 commented 7 years ago

@mgcrea, thanks!

Internally we have a built up control suite which is used across our various projects. I've been really pushing the guys to write unit tests on pretty much everything. You'll notice in this batch of commit notices that I forgot to remove the Change-Id. That's because we use Gerrit.

My goal is to integrate unit tests into both our consumption of Angular-Strap and thus verify our internal commits against a build before code can be committed as well as using our internal Jenkins to do a build similar to what your Travis build does.

Unfortunately, between getting my deliverables completed, reviewing our internal code, and insuring we're compliant with the projects we use it leaves me little to devote to our devops tasks. I have to sneak work on that stuff under the radar. So far I've gotten my team off of TFS and SVN to Git and having CI builds on every commit.

We'll do better on the unit test cases in the future. I guarantee it! Thanks for merging our code!

I may reach out to you soon regarding some 508 work that I'm doing on the datepicker. I have talked with our internal UX team about some changes we may have to make in our product regarding our implementation, but I may also have to reach out to TPG to get clarification on some functionality. Fortunately working with your code is a pleasure!