fix(affix): Use the document instead of the body to determine the height of the page

mgcrea / angular-strap

AngularJS 1.2+ native directives for Bootstrap 3.

mgcrea.github.io/angular-strap

MIT License

5.73k stars 1.38k forks source link

fix(affix): Use the document instead of the body to determine the height of the page #2238

Closed CyborgMaster closed 5 years ago

CyborgMaster commented 7 years ago

In my project, due to fixed height headers and sidebars, the children of the body element are all absolutely, or fixed positioned. This causes the body element to have a height of 0px, and therefore the height calcs in affix to work incorrectly. This is fixed if we use the height of the document instead of the body.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

CyborgMaster commented 5 years ago

I really think this is a good improvement, I would like to get it merged. Can we take another look?