mgcrea / vision-camera-barcode-scanner

High performance barcode scanner for React Native using VisionCamera
MIT License
87 stars 11 forks source link

Issue building on New arch #39

Open projay11 opened 6 days ago

projay11 commented 6 days ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @mgcrea/vision-camera-barcode-scanner@0.11.2 for the project I'm working on.

This fixes an issue building on the new arch

Here is the diff that solved my problem:

diff --git a/node_modules/@mgcrea/vision-camera-barcode-scanner/android/build.gradle b/node_modules/@mgcrea/vision-camera-barcode-scanner/android/build.gradle
index 5c348ac..e8715e7 100644
--- a/node_modules/@mgcrea/vision-camera-barcode-scanner/android/build.gradle
+++ b/node_modules/@mgcrea/vision-camera-barcode-scanner/android/build.gradle
@@ -71,7 +71,7 @@ dependencies {

 if (isNewArchitectureEnabled()) {
   react {
-    jsRootDir = file("../src/")
+    jsRootDir = file("../dist/")
     libraryName = "VisionCameraCodeScanner"
     codegenJavaPackageName = "com.visioncameracodescanner"
   }

This issue body was partially generated by patch-package.