search

mgdm / htmlq

Like jq, but for HTML.
MIT License
7.09k stars 111 forks source link

Homebrew Formula? #12

Closed Olshansk closed 3 years ago

Olshansk commented 3 years ago

Is there a brew formula available to install this?

NikolayMurha commented 3 years ago

https://github.com/Homebrew/homebrew-core/pull/84809

NikolayMurha commented 3 years ago

@mgdm Due this comments we should apply tag to release. Could you make release please?

https://github.com/Homebrew/homebrew-core/pull/84809#pullrequestreview-748091578 https://github.com/Homebrew/homebrew-core/pull/84809#discussion_r703511626

NikolayMurha commented 3 years ago

I made homebrew formula, but I think the project is not active. The author does not accept pull requests and does not respond to issues. I hope someone will support this useful project.

jasonbosco commented 3 years ago

I spoke to the author and he said he’ll take a look at the PRs at the end of his work day.

mgdm commented 3 years ago

Hi! Thanks for doing that I'm evaluating another PR and once I decide what to do with it I'll tag the release.

chenrui333 commented 3 years ago

Thanks @mgdm!

NikolayMurha commented 3 years ago

Congratulations! The formula is merged!

gingerhot commented 3 years ago

I see the installation still depends on cargo, could we just install it in binary? That will be convenient for those who just hope for a command tool and have not a Rust environment. Hope I didn't misunderstand the formula configuration.

Add if we could upload the binaries in releases, that will be easy for people to install by platform manually.

NikolayMurha commented 3 years ago

@gingerhot If we are talking about Homebrew Formula, Homebrew build binaries for different environments, so this is not a big problem. In most cases, the buildfrom sources is not run on the client's machine. In addition, rust is installed as a dependency only for build phase. For other platforms, a binary releases would be better. I hope I understood the essence of the question correctly. Please note that I do not develop in rust and do not know all the nuances of distributing code in this environment.

gingerhot commented 3 years ago

@gingerhot If we are talking about Homebrew Formula, Homebrew build binaries for different environments, so this is not a big problem. In most cases, the buildfrom sources is not run on the client's machine. In addition, rust is installed as a dependency only for build phase. For other platforms, a binary releases would be better. I hope I understood the essence of the question correctly. Please note that I do not develop in rust and do not know all the nuances of distributing code in this environment.

So that is no problem with it. Thank you for your answering.

kaisugi commented 3 years ago

Now that we can install this with Homebrew, why not write about it on README?

Olshansk commented 3 years ago

@HelloRusk Looks like it's already there: curl --silent https://www.rust-lang.org/ | htmlq --attribute href a

I just installed it with brew install htmlq and everything works flawlessly. Thank you!

kaisugi commented 3 years ago

@Olshansk Oh yes, it was in this commit https://github.com/mgdm/htmlq/commit/014ae255b9230d03a0e9dda959796ef997eff5fd