mgear-dev / mgear4

mGear v.4.x.x (python 3 ready) https://mgear4.readthedocs.io
MIT License
259 stars 91 forks source link

Update weightNode_io.py #267

Closed ordinc closed 10 months ago

ordinc commented 10 months ago

Fixed the uninstallation of the "weightDriver" plug-in in the python3 environment (maya2023, maya2024) because the "weightDriver/plug-ins" in line 131 is not in the list on line 130, so the variable value in line 132 is None, This error occurs when comparing row 134. # Error: TypeError: '>' not supported between instances of 'NoneType' and 'str' #

ordinc commented 10 months ago

This update fixes the inability to create the "Enable mGear file drop" and "Help" submenus in the mgear menu due to this bug. The following pictures are from maya2024. before: image

after: image

If "weightDriver/plug-ins" does not exist in the user's plug-in list, it will cause the above-mentioned incomplete menu creation error.

miquelcampos commented 10 months ago

Hi @ordinc thanks for the PR I wonder why I didn't see the error before. Maybe is related if you have or have not installed the plugin SHAPES? Do you have this plugin installed? My menu without your fix looks good image @SimonBenAnderson @ireneweng Can you confirm if you have this issue on your side? Thanks

ordinc commented 10 months ago

Maybe is related if you have or have not installed the plugin SHAPES? Do you have this plugin installed?

Maybe yes, I have SHAPES installed in the 2020 environment, but not in the 2024 environment, so when I installed the latest version of mGear in these two versions, I found that the mGear menu in 2020 is complete, and in 2024 The mGear menu is incomplete (as shown in the screenshot in my previous review).

My menu without your fix looks good

Maybe SHAPES is installed in your current version environment?

miquelcampos commented 10 months ago

Yes I have SHAPES installed in all my Maya versions 😅