rigbits: Gimmick SetupTool bugs and enhancements

mgear-dev / mgear4

mGear v.4.x.x (python 3 ready) https://mgear4.readthedocs.io

MIT License

266 stars 94 forks source link

rigbits: Gimmick SetupTool bugs and enhancements #279

Open miquelcampos opened 1 year ago

miquelcampos commented 1 year ago

some bugs related to: NewFeature: Gimmick SetupTool has been added in rigbits #272

[x] mirror blend joints in default biped is not working
[x] If click mirror with a regular joint selected will break the joint structure connection
[x] change the .json extension to something like .gst this will help add a drag and drop behavior in the future, by making a distinction of the file type
[x] Please add some documentation on how to use the tool. In general is very straightforward, but I didn't get the use of side tagging in the creation section. I think that is inherited from the parent joint, but maybe missing something 😅 Thanks!

joji2468ng commented 1 year ago

Thank you for testing the tool!

I will address all of the identified issues and create documentation.

Currently, the tool relies on joint naming rules derived from a guide node. This approach has limitations, as it requires the presence of a guide node in the scene for the process to proceed.

To improve this, I suggest incorporating the naming rule pattern within the top rig node as an extra attribute. At the same time, we can add a controller naming pattern as well. What do you think?

Thanks!

miquelcampos commented 1 year ago

@joji2468ng since the last release we started embedding the guide description in the rigs. You will find all the information there 😉 https://github.com/mgear-dev/mgear4/issues/248 EDIT: I think we need to remove the dependency of the guide. Maybe is a guide from another rig or we have multiple guides in the scene. That can cause issues

joji2468ng commented 1 year ago

Wow, I found all the information there. it seemed to miss the new feature! I realized that this can cause issues in any case, okay I will fix the part as well.

I will let you know once I finish all of them!

joji2468ng commented 1 year ago

Hi @miquelcampos I've just submitted a pull request with all bugs fixed, and new features. https://github.com/mgear-dev/mgear4/pull/284 I've changed the UI layout and added flip joint buttons as a sub button. Thanks,

joji2468ng commented 1 year ago

Hi @miquelcampos , Thank you for merging the pull request! It seems like the tool menu has been commented out since it was reverted back.

Could you take a look at it when you have time?

Thanks,

miquelcampos commented 1 year ago

@joji2468ng Yes, I know. However I have found some issues while testing it. The issue is when you add a support joint to a blend joint, and mirror. The support joint will not change the side in the name. I will record a video ASAP

joji2468ng commented 1 year ago

I just found out the bug on my end, will fix it ASAP.